Conversation
danielmarbach
requested review from
johnsimons,
jpalac,
lailabougria and
mauroservienti
danielmarbach
force-pushed
the
sqs
branch
2 times, most recently
from
26e2e74 to
83bbdb6
Compare
|
It seems the region endpoint discovery no longer throws an exception but returns "unknown" which causes one of the tests to fail. Stopping for now |
|
There is this method that deals with unknown regions https://github.com/aws/aws-sdk-net/blob/c74b20bd7ea3e4402479067e27bbb495f406e44b/sdk/src/Core/RegionEndpoint/RegionEndpoint.cs#L174 |
This is required because RegionEndpoint.GetBySystemName() returns `unknown` instead of throwing.
|
@danielmarbach, I pushed a commit to it to validate the region input beforehand. |
| if (!IsValidAwsRegion(sqsConnectionString.Region)) | ||
| { | ||
| throw new ArgumentException("Invalid region endpoint provided"); | ||
| } |
There was a problem hiding this comment.
I am unsure if we need this validation here, because i assume the connection string region would already be validated, @danielmarbach ?
There was a problem hiding this comment.
It is validated by the SDK but not by us. It would throw a different exception though indicating an unknown name or host or something like that. This would at least keep the behavior consistent
3 participants
No description provided.